Skip to content

Add upgrade lane for TNA and SNO#79596

Open
kasturinarra wants to merge 1 commit into
openshift:mainfrom
kasturinarra:add_upgrade_lane_tna
Open

Add upgrade lane for TNA and SNO#79596
kasturinarra wants to merge 1 commit into
openshift:mainfrom
kasturinarra:add_upgrade_lane_tna

Conversation

@kasturinarra
Copy link
Copy Markdown
Contributor

@kasturinarra kasturinarra commented May 21, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

This PR updates the OpenShift CI configuration in the openshift/release repository by adding two TechPreview "day-2 OS image = RHEL 10" upgrade lanes to the nightly-5.0-upgrade-from-stable-4.22 variant. These are periodic CI tests that validate RHEL 10 day-2 OS image handling during upgrades from 4.22 → 5.0 across two cluster topologies.

What changed and where

  • File modified: ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml
  • Affects: OpenShift release nightly upgrade CI jobs (periodic/cron definitions that generate Prow jobs).

New/modified test entries

  1. e2e-metal-ovn-two-node-arbiter-techpreview-upgrade-os-rhel10
  • Purpose: Upgrade test for two-node arbiter topology using TechPreview day-2 RHEL 10 OS image.
  • Scheduling: cron '@weekly'
  • Cluster profile: equinix-edge-enablement
  • Key env/config:
    • DEVSCRIPTS_CONFIG (inline) with IP_STACK=v4, NUM_MASTERS=2 (MASTER_MEMORY=32768, MASTER_DISK=100), NUM_ARBITERS=1 (ARBITER_MEMORY=8192, ARBITER_DISK=50, ARBITER_VCPU=2), NUM_WORKERS=0
    • FEATURE_SET="TechPreviewNoUpgrade"
    • MCO_CONF_DAY2_OS_IMAGE_STREAM_DEFAULT: rhel-10
    • TEST_TYPE: upgrade
  • Tests/workflow: test chain includes baremetalds-ipi-test and a ref to mco-conf-day2-os-image-stream-default; workflow = baremetalds-two-node-arbiter-upgrade
  1. e2e-aws-upgrade-ovn-single-node-techpreview-os-rhel10
  • Purpose: Upgrade test for AWS single-node (SNO) topology using TechPreview day-2 RHEL 10 OS image.
  • Scheduling: interval 168h (weekly)
  • Cluster profile: openshift-org-aws
  • Key env/config:
    • FEATURE_SET: TechPreviewNoUpgrade
    • MCO_CONF_DAY2_OS_IMAGE_STREAM_DEFAULT: rhel-10
    • TEST_TYPE: upgrade
    • observers: observers-resource-watch enabled
  • Tests/workflow: includes refs single-node-e2e-test and mco-conf-day2-os-image-stream-default; workflow = openshift-upgrade-aws-single-node

Notes

  • Both jobs focus on validating RHEL 10 day-2 OS image compatibility during OpenShift upgrades under TechPreviewNoUpgrade.
  • Scheduling and cluster profiles differ: Equinix edge for TNA, AWS for SNO; both run weekly.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026 •
edited
Loading

Walkthrough

Adds two nightly upgrade CI job variants targeting RHEL 10 day-2 OS image stream: one metal OVN two-node arbiter upgrade and one AWS single-node OVN upgrade, both using the TechPreviewNoUpgrade feature set.

Changes

RHEL 10 Upgrade Test Cases

Layer / File(s) Summary
Metal OVN two-node arbiter upgrade
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml		 Adds e2e-metal-ovn-two-node-arbiter-techpreview-os-rhel10 with inline DEVSCRIPTS_CONFIG (IP_STACK=v4, 2 masters, 1 arbiter, sized disks/memory/vCPUs), FEATURE_SET="TechPreviewNoUpgrade", MCO_CONF_DAY2_OS_IMAGE_STREAM_DEFAULT: rhel-10, TEST_TYPE: upgrade, and a test list combining the baremetalds chain and the day-2 OS image ref.
AWS single-node OVN upgrade
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml		 Adds e2e-aws-upgrade-ovn-single-node-techpreview-os-rhel10 with FEATURE_SET: TechPreviewNoUpgrade, MCO_CONF_DAY2_OS_IMAGE_STREAM_DEFAULT: rhel-10, TEST_TYPE: upgrade, and test refs including single-node-e2e-test and the day-2 OS image ref using the existing AWS single-node upgrade workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/release#79388: Modifies devscripts environment for upgrade job definitions (both PRs touch IP_STACK/v4 and related devscripts env entries).

Suggested labels

rehearsals-ack

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add upgrade lane for TNA and SNO' directly reflects the main change: introducing upgrade test job variants for two-node arbiter (TNA) and single-node OpenShift (SNO) configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies CI configuration YAML only, not Ginkgo test code. The custom check applies to Ginkgo test names (It(), Describe(), etc.), which are not present in this PR.
Test Structure And Quality ✅ Passed This PR modifies CI configuration files (YAML), not Ginkgo test code. The custom check targets Ginkgo test quality; it is not applicable here.
Microshift Test Compatibility ✅ Passed PR adds only CI job configuration (YAML), not new Ginkgo test code. The custom check applies only to new test definitions, which are absent here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Custom check is not applicable. PR adds CI job configuration only, not new Ginkgo e2e tests. Check requires analysis of test code additions (It(), Describe(), etc.), which are absent.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds CI test configurations for SNO and TNA topologies, not deployment manifests or operator code. No scheduling constraints introduced that would break alternative topologies.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI configuration files, not binary code. OTE Binary Stdout Contract check applies to Go binaries and stdout behavior, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds CI job YAML configurations only, not new Ginkgo test code. The custom check applies only to new test code patterns in Go files, which are not present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from hoxhaeris and stbenjam May 21, 2026 11:49
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasturinarra
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasturinarra
Copy link
Copy Markdown
Contributor Author

kasturinarra commented May 21, 2026

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10 periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 21, 2026

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kasturinarra kasturinarra force-pushed the add_upgrade_lane_tna branch from d092f0d to a854bb8 Compare May 21, 2026 17:56
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 21, 2026

[REHEARSALNOTIFIER]
@kasturinarra: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-techpreview-os-rhel10 N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-techpreview-upgrade-os-rhel10 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

coderabbitai[bot]
coderabbitai Bot reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml`:
- Around line 91-102: The FEATURE_SET value is currently embedded inside the
DEVSCRIPTS_CONFIG multiline string; remove FEATURE_SET="TechPreviewNoUpgrade"
from DEVSCRIPTS_CONFIG and add a new top-level environment variable entry
FEATURE_SET: "TechPreviewNoUpgrade" at the same indentation level as
MCO_CONF_DAY2_OS_IMAGE_STREAM_DEFAULT so it is not part of the dev-scripts block
(refer to DEVSCRIPTS_CONFIG, FEATURE_SET and
MCO_CONF_DAY2_OS_IMAGE_STREAM_DEFAULT to locate the change).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f93e6639-47a5-42be-9d56-663e2233f76a

📥 Commits

Reviewing files that changed from the base of the PR and between d092f0d and a854bb8.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml

Comment thread ...r/config/openshift/release/openshift-release-main__nightly-5.0-upgrade-from-stable-4.22.yaml
@kasturinarra
Copy link
Copy Markdown
Contributor Author

kasturinarra commented May 21, 2026

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10 periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 21, 2026

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 21, 2026

@kasturinarra: job(s): periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10, periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10 either don't exist or were not found to be affected, and cannot be rehearsed

@kasturinarra
Copy link
Copy Markdown
Contributor Author

kasturinarra commented May 21, 2026

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-techpreview-upgrade-os-rhel10 periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-/aws-upgrade-ovn-single-node-techpreview-os-rhel10

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 21, 2026

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 21, 2026

@kasturinarra: job(s): periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-/aws-upgrade-ovn-single-node-techpreview-os-rhel10 either don't exist or were not found to be affected, and cannot be rehearsed

@kasturinarra
Copy link
Copy Markdown
Contributor Author

kasturinarra commented May 21, 2026

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-techpreview-os-rhel10

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 21, 2026

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@kasturinarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-techpreview-upgrade-os-rhel10 a854bb8 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-techpreview-upgrade-os-rhel10
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-techpreview-os-rhel10 a854bb8 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-techpreview-os-rhel10
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10 d092f0d link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-metal-ovn-two-node-arbiter-upgrade-os-rhel10
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10 d092f0d link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node-os-rhel10

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@hoxhaeris hoxhaeris Awaiting requested review from hoxhaeris

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kasturinarra